Do not duplicate comment #1914
Merged
Do not duplicate comment #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
reviewed
Oct 12, 2021
src/Fantomas.Tests/CommentTests.fs
Outdated
| @@ -1558,3 +1558,44 @@ Host | |||
|
|
|||
| // | |||
| """ | |||
|
|
|||
| [<Test>] | |||
| let ``comment should not be duplicated, 1912`` () = | |||
There was a problem hiding this comment.
Could you a slightly more related test name?
Something like comment after bracket in record should not be duplicated in computation expression
There was a problem hiding this comment.
@su8898 same for the commit message title, add "in computation expression" at the end at least
nojaf
reviewed
Oct 12, 2021
src/Fantomas/CodePrinter.fs
Outdated
| @@ -1389,6 +1389,7 @@ and genExpr astContext synExpr ctx = | |||
| ) | |||
|
|
|||
| | CompExpr (isArrayOrList, e) -> | |||
|
|
|||
There was a problem hiding this comment.
Could you remove this newline, please? Keep the git diff as minimal as possible.
su8898
force-pushed
the
DuplicateCommentIssue
branch
from
882ed2d to
392df29
Compare
|
Hi @nojaf many thanks for the review. I've addressed the nits. Could you please take a look? |
nojaf
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1912